| Summary: | memory leak in do_ssh2_kex() routine (sshd.c) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Miguel Sanders <miguel.sanders> | ||||
| Component: | sshd | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED WONTFIX | ||||||
| Severity: | normal | CC: | djm, miguel.sanders | ||||
| Priority: | P2 | ||||||
| Version: | 5.2p1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
I don't think this is worth fixing: myproposal is filled in once (i.e. this leak will not grow in time) and it is useful to have this structure populated. actually, I think we do need this structure around for key re-exchange. Either way, we don't intend to fix this. Mass move of RESOLVED bugs to CLOSED now that 5.3 is out. |
Created attachment 1620 [details] Fix for memory leak There is small memory leak in the do_ssh2_kex() routine in sshd.c. Line 2195 in sshd.c states: myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS] = list_hostkey_types(); Where list_hostkey_types() returns a pointer allocated by the xstrdup call (line 735). This pointer should be freed in the calling routine do_ssh2_kex().