Bug 1629

Summary:	allow --port=#### option at configuration time?
Product:	Portable OpenSSH	Reporter:	mikee <mike.ellis>
Component:	Build system	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	CLOSED WONTFIX
Severity:	enhancement	CC:	dtucker, tim
Priority:	P2
Version:	5.2p1
Hardware:	Other
OS:	Other

Description mikee 2009-08-05 14:29:01 AEST

I used the awesome "make package" option to create a native Solaris package. I wanted to run this version of openSSH on port 2222 instead of port 22, but that now meant I had to "pkgtrans the package" that "make package" created, edit the config-file, and re-pack it.

If at "./configure time" you could specify certain variables such as port, pidfile, and potentially some others that would work their way all the way into the sshd config file, the "make package" produced package would be immediately useable.

just a thought.

thanks,
 
-- MikeE

Comment 1 Darren Tucker 2009-08-05 23:11:24 AEST

Why don't you just do "echo PidFile /some/file.pid >> sshd_config" before running "make package"?

Comment 2 mikee 2009-08-06 00:33:33 AEST

(In reply to comment #1)
> Why don't you just do "echo PidFile /some/file.pid >> sshd_config"
> before running "make package"?


Fair enough -- so the way to do this is basically to pre-edit the config-file template, so that its cooked into the final package.

Having those entries available as "options" to ./configure would seem like a reasonable place to have them, maybe as some sort of free-form --options=xxx=###,zzz=yyy which will customize those options into the sshdconfig files. 

thanks for the suggestion on how to do this.

Comment 3 Tim Rice 2009-08-06 03:36:24 AEST

(In reply to comment #2)
> (In reply to comment #1)
> > Why don't you just do "echo PidFile /some/file.pid >> sshd_config"
> > before running "make package"?
> 
> 
> Fair enough -- so the way to do this is basically to pre-edit the
> config-file template, so that its cooked into the final package.

Or create pkg-post-make-install-fixes.sh script to modify sshd_config installed in $FAKE_ROOT
pkg-post-make-install-fixes.sh will be run as part of "make package"

Comment 4 Darren Tucker 2009-08-20 23:17:45 AEST

configure is already quite the monster so I don't think it's a good idea to introduce additional monsterism to handle something that can be done in a line or two of shell.  Thanks anyway but I don't think we'll be doing this.

Comment 5 Damien Miller 2009-10-06 15:02:14 AEDT

Mass move of RESOLVED bugs to CLOSED now that 5.3 is out.