Bug 1725

Summary: use x11.pc when linking gnome-ssh-askpass2
Product: Portable OpenSSH Reporter: Colin Watson <cjwatson>
Component: Build systemAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: normal CC: dtucker
Priority: P2    
Version: 5.3p1   
Hardware: Other   
OS: Linux   
URL: http://bugs.debian.org/555951
Bug Depends on:    
Bug Blocks: 1743    
Attachments:
Description Flags
explicitly link against libX11 none

Description Colin Watson 2010-03-02 00:51:55 AEDT
Created attachment 1799 [details]
explicitly link against libX11

The new 'gold' linker in binutils is a little stricter than traditional ld; in particular, it defaults to --no-add-needed, which effectively means that it requires applications to explicitly link against libraries that provide functions that they explicitly call.  (Obviously inter-library linkage doesn't have to be specified by the application - that would be unreasonable.)

Since gnome-ssh-askpass2 uses XUngrabServer (incidentally, why doesn't it use gdk_x11_ungrab_server to go with the existing call to gdk_x11_grab_server?), it should link against libX11 itself as well as relying on libgdk-x11's linkage.
Comment 1 Darren Tucker 2010-03-26 11:17:10 AEDT
Patch applied, it will be in 5.5p1.  Thanks.
Comment 2 Damien Miller 2010-04-16 15:49:56 AEST
Mass move of bugs RESOLVED->CLOSED following the release of openssh-5.5p1