Bug 1783

Summary: ssh-keygen -L and -l give misleading error messages when fopen() fails
Product: Portable OpenSSH Reporter: Iain Morgan <imorgan>
Component: ssh-keygenAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: minor CC: djm
Priority: P2    
Version: -current   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 1708    
Attachments:
Description Flags
fatal() with a useful message if fopen() fails
none
/home/djm/keygen-load-errors.diff dtucker: ok+

Description Iain Morgan 2010-06-16 03:57:18 AEST
Created attachment 1861 [details]
fatal() with a useful message if fopen() fails

ssh-keygen -L (and -l) will report misleading error messages if the
fopen() of the specified file fails. This may cause ssh-keygen to
complain about the format of the file when the real issue is a lack
of read permissions, etc.

The attached patch reports a more accurate error message
when fopen() fails in these cases.
Comment 1 Damien Miller 2010-06-18 10:49:53 AEST
Created attachment 1864 [details]
/home/djm/keygen-load-errors.diff

standardise format of a few more keyfile opens
Comment 2 Damien Miller 2010-06-22 14:36:30 AEST
patch applied - this will be released in OpenSSH-5.6. Thanks!
Comment 3 Damien Miller 2011-01-24 12:33:40 AEDT
Move resolved bugs to CLOSED after 5.7 release