Bug 1796

Summary: Error on rpmbuild while compiling RPMS from tar.gz
Product: Portable OpenSSH Reporter: adam
Component: Build systemAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: minor CC: tim
Priority: P2    
Version: 5.5p1   
Hardware: All   
OS: All   

Description adam 2010-07-15 03:29:39 AEST
while doing a "rpmbuild -bb openssh.spec" and having enabled building of x11-askpass:



error: /usr/src/redhat/SPECS/openssh.spec:77: parseExpressionBoolean returns -1

there was a line in the spec file (line 77) read the following:

%if ! %{no_x11_askpass}

However the defined var is listed at the top of the file as "skip_x11_askpass"

I replace line 77 with the following:

%if ! %{skip_x11_askpass}

and the problem was resolved.
Comment 1 Tim Rice 2010-07-15 06:50:04 AEST
It looks like your explanation is reversed.
I've committed the fix.
It will be in 5.6 when it is released and the next snapshot.
Comment 2 adam 2010-07-15 06:59:55 AEST
You are correct:

%if ! %{skip_x11_askpass}


should be

%if ! %{no_x11_askpass}

My apologizes.
Comment 3 Darren Tucker 2010-08-27 10:28:04 AEST
With the release of OpenSSH 5.6p1 this bug is now considered closed.  If you have further problems please reopen or file a new bug as appropriate.