Bug 1870

Summary:

Do not show VisualHostKey unless attached to a terminal

Product:

Portable OpenSSH

Reporter:

Joachim Breitner <mail>

Component:

ssh

Assignee:

Assigned to nobody <unassigned-bugs>

Status:

NEW ---

Severity:

normal

CC:

djm, simon

Priority:

Version:

5.5p1

Hardware:

All

OS:

All

Attachments:

Description	Flags
/home/djm/bz1870.diff	none

Description Joachim Breitner 2011-02-24 19:12:16 AEDT

Hi,

as discussed on http://bugs.debian.org/511120, the VisualHostKey feature will cause visual host keys appear even in the output of automated scripts, e.g. backup scripts, where there is little gain and only inconvenience (or breakage).

A possible remedy could be to show the VisualHostKey only when attached to a terminal, and otherwise not.

Thanks
Joachim

Comment 1 Damien Miller 2011-05-20 12:11:14 AEST

Created attachment 2048 [details]
/home/djm/bz1870.diff

silence VisualHostKey for non-interactive && non-ttyful connections

Comment 2 Damien Miller 2011-05-20 12:11:34 AEST

Does this patch work for you?

Comment 3 Damien Miller 2011-09-06 10:34:17 AEST

Retarget unresolved bugs/features to 6.0 release

Comment 4 Damien Miller 2011-09-06 10:36:29 AEST

Retarget unresolved bugs/features to 6.0 release

Comment 5 Damien Miller 2011-09-06 10:39:04 AEST

Retarget unresolved bugs/features to 6.0 release

(try again - bugzilla's "change several" isn't)

Comment 6 Damien Miller 2012-02-24 10:34:25 AEDT

Retarget from 6.0 to 6.1

Comment 7 Damien Miller 2012-02-24 10:38:04 AEDT

Retarget 6.0 => 6.1

Comment 8 Damien Miller 2012-09-07 11:38:05 AEST

Retarget uncompleted bugs from 6.1 => 6.2

Comment 9 Damien Miller 2012-09-07 11:40:34 AEST

Retarget bugs from 6.1 => 6.2

Comment 10 Damien Miller 2013-02-08 11:26:45 AEDT

2nd thought. Rather than depending on a terminal maybe it should check options.batch_mode?

Comment 11 Damien Miller 2013-03-08 10:23:45 AEDT

retarget to openssh-6.3

Comment 12 Damien Miller 2013-07-25 12:17:44 AEST

Retarget to openssh-6.4

Comment 13 Damien Miller 2013-07-25 12:20:39 AEST

Retarget 6.3 -> 6.4

Comment 14 Damien Miller 2013-12-05 10:28:49 AEDT

Removing target until OP shows up to test the patch.

Comment 15 Joachim Breitner 2013-12-05 10:50:40 AEDT

Sorry, for some reason I missed the request to test a patch.

I haven’t build openssh before, so I’d first have to look into that. Not sure when I’ll get to that (since a while I simply disabled VisualHostKeys, due to the issue, so the itch is not so itchy any more). The patch looks good, though, thanks!