Bug 196

Summary:

wront sent message id on upload

Product:

Portable OpenSSH

Reporter:

Jean-Pierre Stierlin <chombier>

Component:

sftp

Assignee:

OpenSSH Bugzilla mailing list <openssh-bugs>

Status:

CLOSED FIXED

Severity:

major

Priority:

Version:

-current

Hardware:

All

OS:

Other

Attachments:

Description	Flags
Fix for id clobbering	none

Description Jean-Pierre Stierlin 2002-04-02 01:35:08 AEST

In sftp_client.c, do_upload() function, the 'id' variable is used for both the 
sent and the received message ids, this corrupts the id of the messages 
to send and randomly generates upload failures.

The fix is to use another variable to extract the received message id, 
status_id, as done in do_download()

Comment 1 Damien Miller 2002-04-02 11:30:06 AEST

Created attachment 58 [details]
Fix for id clobbering

Comment 2 Damien Miller 2002-04-02 11:31:31 AEST

Thanks for spotting this - can you please try the attached patch?

Comment 3 Damien Miller 2002-04-06 10:35:09 AEST

Fix committed to OpenBSD CVS

Comment 4 Damien Miller 2004-04-14 12:24:18 AEST

Mass change of RESOLVED bugs to CLOSED