Bug 2039

Summary:	Give proper credits for ECDSA patch
Product:	Portable OpenSSH	Reporter:	Ondřej Surý <ondrej>
Component:	Documentation	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	CLOSED FIXED
Severity:	normal	CC:	daniel.black, dtucker
Priority:	P5
Version:	6.1p1
Hardware:	All
OS:	All

Description Ondřej Surý 2012-08-31 16:50:09 AEST

Hi,

ChangeLog for 6.1p1 says:

   - djm@cvs.openbsd.org 2012/05/23 03:28:28
     [dns.c dns.h key.c key.h ssh-keygen.c]
     add support for RFC6594 SSHFP DNS records for ECDSA key types.
     patch from bugzilla-m67 AT nulld.me in bz#1978; ok + tweak markus@

while the patch from the bug report was created by me - Ondřej Surý <ondrej@sury.org> - with contributions from Ondřej Caletka and Daniel Black, as you can confirm from the original source of the patch: https://git.nic.cz/redmine/projects/ietf/repository/revisions/master/changes/ssh-sshfp-ecdsa.patch

Please fix in next release, thank you,
Ondřej Surý

Comment 1 Darren Tucker 2012-09-07 10:47:59 AEST

we can't retroactively change the commit message and that's what's in the ChangeLog, so I added a line following acknowledging the original authorship.  Hope that's sufficient, it should be here: http://anoncvs.mindrot.org/index.cgi/openssh/ChangeLog?r1=1.6109&r2=1.6110 once the anoncvs mirror catches up.

Comment 2 Ondřej Surý 2012-09-07 17:24:21 AEST

The solution is ok with me, but just a small nit - you (or CVS) got my name wrong in the patch.  The Latin-2 characters (ř) are OK, but the 'ý' in Surý got mangled somehow to non-UTF-8 character (\303).


+     (Original authors Ond\305\231ej Sur\303,  Ond\305\231ej Caletka and Daniel Black)                                                                                                             

should be

+     (Original authors Ond\305\231ej Sur\303\275, Ond\305\231ej Caletka and Daniel Black)

Comment 3 Darren Tucker 2012-09-07 18:10:06 AEST

(In reply to comment #2)
> The solution is ok with me, but just a small nit - you (or CVS) got
> my name wrong in the patch.  The Latin-2 characters (ř) are OK, but
> the 'ý' in Surý got mangled somehow to non-UTF-8 character (\303).

Sorry about that, fixed (I think, od -ba shows the octal characters above).

Comment 4 Ondřej Surý 2012-09-07 18:29:52 AEST

LGTM, thank you very much!

Comment 5 Daniel Black 2012-12-07 12:07:19 AEDT

thanks Darren and Ondřej.

Comment 6 Damien Miller 2015-08-11 23:04:15 AEST

Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1