| Summary: | invalid prototype for get_last_login_time() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Arthur Mesh <arthurmesh> | ||||
| Component: | Build system | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | enhancement | CC: | djm, dtucker | ||||
| Priority: | P5 | ||||||
| Version: | 6.2p1 | ||||||
| Hardware: | Other | ||||||
| OS: | FreeBSD | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2076 | ||||||
| Attachments: |
|
||||||
What options did you use to catch this? Neither gcc nor clang/llvm-3.3 noticed this for me. In any case, applied - nice catch. It was caught using GCC 4.2.1 (with some unknown to me patches), using the following set of -Ws: -Wno-pointer-sign -Wno-error=address -W -Wall -Wcast-align -Wchar-subscripts -Wcomment -Werror -Wextra -Wformat -Wimplicit -Winline -Wmissing-declarations -Wmissing-prototypes -Wparentheses -Wpointer-arith -Wreturn-type -Wshadow -Wstrict-aliasing -Wstrict-prototypes -Wswitch -Wtrigraphs -Wuninitialized -Wno-unused-parameter -Wno-unused I am not sure which, if any of these, are causing the warning. Close all resolved bugs after 7.3p1 release |
Created attachment 2321 [details] proposed fix simple fix -- found when building OpenSSH with stricter warning sets.