| Summary: | progress meter shows wrong speed during resume | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Loganaden Velvindron <loganaden> | ||||||
| Component: | sftp | Assignee: | Assigned to nobody <unassigned-bugs> | ||||||
| Status: | CLOSED FIXED | ||||||||
| Severity: | minor | CC: | djm, dtucker, imorgan | ||||||
| Priority: | P5 | ||||||||
| Version: | -current | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 2130 | ||||||||
| Attachments: |
|
||||||||
Created attachment 2333 [details]
Don't assume that the starting poistion is zero
This looks like it fixes the issue. Save the initial offset when starting the progress meter and use it when cur_pos is zero. Also, use it when reporting the statistics for the completed transfer. This also fixes the negative speed issue when the transfer is interrupted by a signal.
patch applied; thanks Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1 |
Created attachment 2324 [details] progressmeter diff Iain Morgan reported that the progress meter would display erroneous speeds when interrupting and resuming downloads. I'm attaching a WIP fix.