| Summary: | Call to upload_dir() has pflag and printflag swapped | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Iain Morgan <imorgan> | ||||
| Component: | sftp | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | trivial | CC: | djm | ||||
| Priority: | P5 | ||||||
| Version: | -current | ||||||
| Hardware: | Other | ||||||
| OS: | Other | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2130 | ||||||
| Attachments: |
|
||||||
applied - thanks. Close all resolved bugs after 7.3p1 release |
Created attachment 2331 [details] Make definition match actual usage. While working on a patch for sftp(1), I noticed that the pflag and This seems to have been the case since the initial inclusion in 5.4. sftp.c-718- if (!quiet) sftp.c-719- printf("Uploading %s to %s\n", g.gl_pathv[i], abs_dst); sftp.c-720- if (pathname_is_dir(g.gl_pathv[i]) && (rflag || global_rflag)) { sftp.c:721: if (upload_dir(conn, g.gl_pathv[i], abs_dst, sftp.c-722- pflag || global_pflag, 1) == -1) sftp.c-723- err = -1; sftp.c-724- } else { -- sftp-client.c-1643-} sftp-client.c-1644- sftp-client.c-1645-int sftp-client.c:1646:upload_dir(struct sftp_conn *conn, char *src, char *dst, int printflag, sftp-client.c-1647- int pflag) sftp-client.c-1648-{ sftp-client.c-1649- char *dst_canon;