| Summary: | Simplify handling of sftp(1) command flags | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Iain Morgan <imorgan> | ||||
| Component: | sftp | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | NEW --- | ||||||
| Severity: | enhancement | CC: | djm | ||||
| Priority: | P5 | ||||||
| Version: | -current | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Retarget incomplete bugs / feature requests to 6.6 release Retarget incomplete bugs / feature requests to 6.6 release Retarget to 6.7 release, since 6.6 was mostly bugfixing. Remove from 6.6 tracking bug Retarget incomplete bugs to 6.8 release. These bugs are no longer targeted at the imminent 6.7 release OpenSSH 6.8 is approaching release and closed for major work. Retarget these bugs for the next release. Retarget to 6.9 this isn't going to make 6.9 |
Created attachment 2332 [details] Use a struct to pass command flags Currently, the flags used with various sftp(1) commands are handled as separate integer variables. This, unfortunately, means that whenever a new flag is needed there can be a lot of tedious work updating all of the relevant function definitions, declarations and calls. Instead, it would seem to be more flexible to pass a single structure which contains the various individual flags. The attached file is an attempt at such an overhaul of the sftp(1) code. In a few cases, where only a single flag is needed, the appropriate structure element is used in the function call in order to reduce the amount of code changed. No changes in overall functionality are intended. A possible enhancement to this patch would be to replace the use of the printflag variable with an element in the structure. The patch applies cleanly against -current and the regression tests all pass. Preliminary manual testing has not uncovered any bugs, but it is still early in the testing process. Hopefully, this will ease the process of adding new features and flags in the future.