| Summary: | ssh-agent crashes when removing PKCS#11 library keys if non-PKCS#11 keys are present | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | jay | ||||||
| Component: | ssh-agent | Assignee: | Damien Miller <djm> | ||||||
| Status: | CLOSED FIXED | ||||||||
| Severity: | minor | CC: | djm, dtucker | ||||||
| Priority: | P5 | ||||||||
| Version: | 6.3p1 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 2130 | ||||||||
| Attachments: |
|
||||||||
Created attachment 2394 [details]
tweaked patch
Nice catch - thanks.
I think a comment is in order here (implemented in tweaked patch).
Does anything else need to be done to get this patch applied? oops. This was committed back in December and made it into the 6.5 release, but unfortunately not the release notes. https://anongit.mindrot.org/openssh.git/commit/?h=V_6_5&id=0b36c83148976c7c8268f4f41497359e2fb26251 oops, added to wrong tracking bug; should have been 6.5 Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1 |
Created attachment 2391 [details] openssh-6.3p1-agent.patch When removing a PKCS#11 key from the agent, the agent crashes if file-based keys are present in the agent. I discovered this was because strcmp() is called on the provider of each key, but the provider is NULL for file keys. The attached patch remedies this by checking for a NULL provider first.