| Summary: | [visual host key] fix upper border display | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Christian Hesse <mail> | ||||||||||
| Component: | ssh | Assignee: | Damien Miller <djm> | ||||||||||
| Status: | CLOSED FIXED | ||||||||||||
| Severity: | minor | CC: | djm, sf | ||||||||||
| Priority: | P5 | ||||||||||||
| Version: | 6.6p1 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 2226 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 2443 [details]
rework printing for visual host key upper border
updated patch to avoid useless sprinf, use simple loop instead.
Put this on the list for openssh-6.7 Created attachment 2444 [details]
rework printing for visual host key upper border
Update to latest git master.
Created attachment 2445 [details]
committed patch
That patch doesn't quite fit ED25519-CERT. This one drops the length when it can't fit.
patch committed. This will be in openssh-6.7 *** Bug 2215 has been marked as a duplicate of this bug. *** Close all bugs left open from 6.6 and 6.7 releases. |
Created attachment 2442 [details] rework printing for visual host key upper border I've sent this patch to mailing list twice, without getting any feedback. Key types are getting longer and the current implementation of visual host key breaks with ED25519, resulting in (note the missing bracket): +--[ED25519 256--+ This reworks the calculation of visual host key upper border. Please be aware that this slightly modifies the output for other key types as well: +--[ DSA 1024]----+ +---[DSA 1024]----+ +--[ RSA 2048]----+ +---[RSA 2048]----+ +--[ECDSA 256]---+ +---[ECDSA 256]---+ +--[ED25519 256--+ +--[ED25519 256]--+