| Summary: | 'configure --disable-lastlog' should mark PrintLastLog as unsupported in servconf.c | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | brent.paulson | ||||
| Component: | sshd | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | minor | CC: | djm, tomas.kuthan | ||||
| Priority: | P5 | ||||||
| Version: | 6.6p1 | ||||||
| Hardware: | All | ||||||
| OS: | Solaris | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2266 | ||||||
| Attachments: |
|
||||||
applied - thanks! commit 5a1284bba78f51d09c6f6a7cdec60a7584d55263 Author: Damien Miller <djm@google.com> Date: Thu Dec 18 17:43:04 2014 +1100 turn off PrintLastLog when --disable-lastlog bz#2278 from Brent Paulson openssh-6.8 is released That's weird: referenced commit 5a1284bba78f51d09c6f6a7cdec60a7584d55263 does not exist on github and the patch is not applied to HEAD nor 6.8p1. Not sure what happened there - I've reapplied the patch and it will be in openssh-7.2 |
Created attachment 2476 [details] mark PrintLastLog as unsupported if DISABLE_LASTLOG is true It is possible to disable all lastlog references in OpenSSH by using the following configure option: --disable-lastlog disable use of lastlog even if detected This also has the side-effect of removing support for the 'PrintLastLog' sshd_config(8) keyword although it is still parsed and processed in servconf.c as if it were possible to change. The sshd_config(8) man page describes the PrintLastLog option as: PrintLastLog Specifies whether sshd(1M) should print the date and time of the last user login when a user logs in interactively. The default is ``yes''. Thus, in line with other sshd_config(8) keywords which are no longer available when the associated functionality is disabled I'd like to propose patching servconf.c to mark 'printlastlog' as unsupported if DISABLE_LASTLOG is set.