| Summary: | NESTING_INDENT_MISMATCH: missing parenthesis around if body in ssh-keygen.c:724 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Jakub Jelen <jjelen> | ||||
| Component: | ssh-keygen | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | normal | CC: | djm | ||||
| Priority: | P5 | ||||||
| Version: | 6.7p1 | ||||||
| Hardware: | Other | ||||||
| OS: | Linux | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2266 | ||||||
| Attachments: |
|
||||||
Applied - will be in openssh-6.8. Thanks! openssh-6.8 is released |
Created attachment 2538 [details] patch Our coverity scan on openssh found one defect - body of function in above mentioned line is not in parenthesis so it doesn't do what it is supposed to do or if it does, it is pretty confusing by the indentation. It probably does what it is supposed to do, because sshkey_write probably fails with private key, but I wouldn't rely on it. This problem is there quite long, since 44b25040110a224a79ff371ee548be9a10ba8bfa, Fri Jul 2 13:35:01 2010 For patch (demonstration) see attachment.