Bug 2410

Summary:	auth-chall.c - "<stdarg.h>" #included twice
Product:	Portable OpenSSH	Reporter:	aab
Component:	Miscellaneous	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	CLOSED FIXED
Severity:	enhancement	CC:	dtucker
Priority:	P5
Version:	6.8p1
Hardware:	Other
OS:	Other
Bug Depends on:
Bug Blocks:	2360

Description aab 2015-06-04 13:04:50 AEST

The "stdarg.h" header file is included twice in "auth-chall.c".  It doesn't hurt anything (at least on the systems with which I'm familiar).

Comment 1 Darren Tucker 2015-06-04 14:09:27 AEST

Looks like the 2nd one was added in -portable in 2006 ("Lots of headers for SCO OSR6, mainly adding stdarg.h for log.h") and then in 2014 it was added in OpenBSD ("New key API: refactor key-related functions to be more library-like"), rendering the 2nd, older one redundant.

Comment 2 Darren Tucker 2015-06-04 14:12:54 AEST

Fixed, thanks!  It will be in the 6.9p1 release.

Comment 3 Damien Miller 2016-08-02 10:40:54 AEST

Close all resolved bugs after 7.3p1 release