Bug 2644

Summary: [PATCH] set uid for functions that use it to seek in lastlog and wtmp files
Product: Portable OpenSSH Reporter: Alexander Naumov <posix.ru>
Component: sshdAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED WORKSFORME    
Severity: enhancement CC: djm
Priority: P5    
Version: 7.2p2   
Hardware: amd64   
OS: Linux   

Description Alexander Naumov 2016-11-27 07:09:17 AEDT
Set uid for functions that use it to seek in lastlog and wtmp files:


diff --git a/sshlogin.c b/sshlogin.c
index cea3e76..0fcae4c 100644
--- a/sshlogin.c
+++ b/sshlogin.c
@@ -134,6 +134,7 @@ record_login(pid_t pid, const char *tty, const char *user, uid_t uid,
 
        li = login_alloc_entry(pid, user, host, tty);
        login_set_addr(li, addr, addrlen);
+       li->uid = uid;
        login_login(li);
        login_free_entry(li);
 }
Comment 1 Damien Miller 2018-01-05 13:31:42 AEDT
This shouldn't necessary - login_alloc_entry() calls login_init_entry() that sets li->uid from the username.
Comment 2 Damien Miller 2021-04-23 14:58:48 AEST
closing resolved bugs as of 8.6p1 release