Bug 2732

Summary:	select() is not called properly in ssh_exchange_identification()
Product:	Portable OpenSSH	Reporter:	balu <bagajjal>
Component:	ssh	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	CLOSED FIXED
Severity:	major	CC:	djm
Priority:	P5
Version:	7.5p1
Hardware:	Other
OS:	Other
Bug Depends on:
Bug Blocks:	2698

Description balu 2017-06-24 12:11:23 AEST

I found an issue with select() not called properly in the ssh_exchange_identification().

Variable "fdset" is passed as readfd, exceptionfd to the select().
Select() should be called with independent fdset so we should have two different variables instead of reusing the same variable "fdset".
The reported issue is in line 566, 567 (sshconnect.c file).

Comment 1 Damien Miller 2017-06-24 18:14:33 AEST

Thanks for reminding me. This has been committed and will be in openssh-7.6

https://anongit.mindrot.org/openssh.git/commit/?id=4540428cd0adf039bcf5a8a27f2d5cdf09191513

Comment 2 Damien Miller 2021-04-23 14:56:30 AEST

closing resolved bugs as of 8.6p1 release