Bug 2868

Summary: Vague error/debug message in src/usr.bin/ssh/key.c
Product: Portable OpenSSH Reporter: Scott <scott_fields>
Component: sshAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED WONTFIX    
Severity: enhancement CC: djm
Priority: P5    
Version: 7.4p1   
Hardware: All   
OS: All   

Description Scott 2018-05-17 10:07:29 AEST
There are several key load functions that all simply report the following in src/usr.bin/ssh/key.c:

debug("%s: %s", __func__, ssh_err(r));

or

error("%s: %s", __func__, ssh_err(r));

That's very vague, especially for an error message.

I'm specifically referring to the following functions.

key_load_cert()
key_load_public()
key_load_private()
key_load_private_cert()
key_load_private_type()

Unless there is a reason to not include this, I would find it very desirable to at least include the file that has the exception being reported in the debug or error message.
Comment 1 Damien Miller 2018-05-17 10:13:32 AEST
They key.c functions are deprecated and in the process of being removed. So those messages will go.
Comment 2 Damien Miller 2021-04-23 15:02:03 AEST
closing resolved bugs as of 8.6p1 release