| Summary: | Shellcheck reports on ssh-copy-id | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Jakub Jelen <jjelen> | ||||
| Component: | ssh-copy-id | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | enhancement | CC: | djm, dtucker, phil | ||||
| Priority: | P5 | ||||||
| Version: | 7.7p1 | ||||||
| Hardware: | Other | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
The upstream for this is http://git.hands.com/ssh-copy-id (In reply to Jakub Jelen from comment #0) > Running shellcheck on the ssh-copy-id results in several reports. > ... Thanks for the suggestion -- sorry it took me so long to get to it. Prompted by this, I've run shellcheck on the latest version, and since it seemed sensible I've patched things to produce a quiet report. You can see the result here: https://gitlab.com/phil_hands/ssh-copy-id/-/commit/f0da1a1b7d86a6254d6c234b1560e2cfafe18d58 Cheers, Phil. closing resolved bugs as of 8.6p1 release |
Created attachment 3175 [details] proposed patches Running shellcheck on the ssh-copy-id results in several reports. Nothing significant that would need immediate attention, but minor fixes and cleanups: * Bogus argument to printf (copy&paste error) * It gets confused on the variable initialization on a single line without single quotes