| Summary: | Typos and copy-paste errors in the code (openbsd-compat/bsd-misc.c) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Samuel <samuel> | ||||
| Component: | Miscellaneous | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | enhancement | CC: | dtucker, samuel | ||||
| Priority: | P5 | ||||||
| Version: | 8.0p1 | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2988 | ||||||
| Attachments: |
|
||||||
Applied, thanks. closing resolved bugs as of 8.6p1 release |
Created attachment 3311 [details] Fix errors in openbsd-compat/bsd-misc.c In the new code for 8.0 in openbsd-compat/bsd-misc.c in the functions "fchownat" and "fchmodat" there are a number of errors: In fchownat at line 178: # ifndef HAVE_FCHOWN return chown(pathname, owner, group); # else There is no parameter called "pathname", it should simply be "path" Same goes for the function "fchmodat" at line 209: # ifndef HAVE_FCHOWN return chown(pathname, owner, group); # else The parameter should be "path", and judging by the function name and the ifndef, the call should probably be chmod instead: # ifndef HAVE_FCHMOD return chmod(path, mode); # else Attached my patch.