Bug 3296

Summary: Avoid possible NULL pointer dereference in monitor.c
Product: Portable OpenSSH Reporter: Xidong Wang <wangxidong>
Component: MiscellaneousAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED WONTFIX    
Severity: enhancement CC: djm
Priority: P5    
Version: 8.5p1   
Hardware: Other   
OS: Windows 10   
Attachments:
Description Flags
mm_answer_term() in file monitor.c none

Description Xidong Wang 2021-04-11 14:43:35 AEST
Created attachment 3496 [details]
mm_answer_term() in file monitor.c

In function mm_answer_term() in file monitor.c, it's better to check whether pmonitor is NULL before it's dereferenced in line 1643.
Comment 1 Damien Miller 2021-04-12 17:05:04 AEST
There should be no situations in which pmonitor can be NULL in the function, as the calling function monitor_read() references is before and after the call
Comment 2 Damien Miller 2022-02-25 13:59:07 AEDT
closing bugs resolved before openssh-8.9