| Summary: | syntax error in bsd-misc.c / utimes() | ||
|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Gert Doering <gert> |
| Component: | Build system | Assignee: | OpenSSH Bugzilla mailing list <openssh-bugs> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | -current | ||
| Hardware: | ix86 | ||
| OS: | Other | ||
Tim and I are talking about this. I need to fix my version that I commited of this to current. This breaks UnixWare since UnixWare does not seem to handle it right for some odd reason. - Ben Well, what's in there is syntacticatlly incorrect (gcc barfs about the "->", as tvp[0]-> will do a double dereference on a single pointer), and it's also semantically incorrect as the second value should not be tv_*u*sec. What is breaking on UnixWare? UnixWare is happy with Gert's patch. Already commited. I'd like to know what NeXT did not mind it. I'll have to test it when I get home. Mass change of RESOLVED bugs to CLOSED |
bsd-misc.c needs the following patch to compile on SCO 3.2v4.2 (which has no utimes()). I did not test this, just tried to adapt the code to what the utimes() man pages on FreeBSD says it should do. Someone needs more coffee here :-) -------- snip -------- --- bsd-misc.c 3 Jul 2002 23:50:00 -0000 1.9 +++ bsd-misc.c 8 Jul 2002 19:30:26 -0000 @@ -93,8 +93,8 @@ { struct utimbuf ub; - ub.actime = tvp[0]->tv_sec; - ub.modtime = tvp[1]->tv_usec; + ub.actime = tvp[0].tv_sec; + ub.modtime = tvp[1].tv_sec; return(utime(filename, &ub)); }