Bug 591

Summary:

use PKCS#15 private key label as a comment in case of OpenSC

Product:

Portable OpenSSH

Reporter:

Nils Larsch <larsch>

Component:

Smartcard

Assignee:

OpenSSH Bugzilla mailing list <openssh-bugs>

Status:

CLOSED FIXED

Severity:

enhancement

Priority:

Version:

-current

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
suggested patch	none
changes to openbsd.	none
new patch for the portable release (based on Markus openbsd patch)	none
fix: sc_get_key_label should not return NULL	none

Description Nils Larsch 2003-06-10 21:18:54 AEST

Attached is patch with which the ssh-agent will use the optional PKCS#15
private key label (if existing) as the comment for the smartcard key
(instead of the standard comment "smartcard key"). In case sc_get_key_label
returns NULL the standard comment is used.

Comments etc. are welcome,
Nils

Comment 1 Nils Larsch 2003-06-10 21:22:47 AEST

Created attachment 325 [details]
suggested patch

Comment 2 Markus Friedl 2003-06-13 05:13:39 AEST

Created attachment 326 [details]
changes to openbsd.

i've commited this to openbsd.

ssh and ssh-agent assume that sc_get_key_label() always
return a xfree()-able string.

Comment 3 Nils Larsch 2003-06-17 20:21:33 AEST

Hi Markus, applying your patch to the portable cvs version and patching
scard-opensc.c with my patch (plus removing the 'const' in the sc_get_key_label
argument in scard-opensc.c) works fine for me with OpenSC.

Comment 4 Nils Larsch 2003-06-17 21:14:59 AEST

Created attachment 329 [details]
new patch for the portable release (based on Markus openbsd patch)

Comment 5 Nils Larsch 2003-06-17 23:28:18 AEST

Created attachment 330 [details]
fix: sc_get_key_label should *not* return NULL

Comment 6 Damien Miller 2003-06-28 18:02:59 AEST

Applied - thanks.

Comment 7 Damien Miller 2004-04-14 12:31:27 AEST

Mass change of VERIFIED bugs to CLOSED