| Summary: | sshd bus faults (64bit) or segfaults (32bit) when reading /etc/default/login | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Darren Tucker <dtucker> | ||||||
| Component: | sshd | Assignee: | OpenSSH Bugzilla mailing list <openssh-bugs> | ||||||
| Status: | CLOSED FIXED | ||||||||
| Severity: | critical | ||||||||
| Priority: | P1 | ||||||||
| Version: | -current | ||||||||
| Hardware: | UltraSPARC | ||||||||
| OS: | Solaris | ||||||||
| Attachments: |
|
||||||||
|
Description
Darren Tucker
2003-09-17 10:13:56 AEST
Created attachment 402 [details]
Fix size_t -> u_int
Created attachment 410 [details]
Check for missing /etc/default/login
Test for NULL pointer deref when /etc/default/login does not exist.
Patch from Georg Oppenberg (georg.oppenberg at deu mci com)
while the workaround is fine if you know at compile time, that /etc/default/login is not existing or not readable, it creates problems, if this is changed at a later time. E.g. using the TITAN system hardening scripts sets this to non-user-readable. login to sshd will silently fail without an explanation. Had a hard time figuring out the cause of this. Agreed about the work-around, but attachment id #410 seems to solve it properly for me (tested Solaris 8, sun4m, unreadable and missing file). If /etc/default/login is not readable by the user, you won't get the settings in it, though. Have committed patch to both HEAD and 3.7 branch. Mass change of RESOLVED bugs to CLOSED |