| Summary: | Compiler warnings in auth-pam.c | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Paul Bolton <paul.a.bolton> | ||||||||
| Component: | PAM support | Assignee: | OpenSSH Bugzilla mailing list <openssh-bugs> | ||||||||
| Status: | CLOSED FIXED | ||||||||||
| Severity: | normal | ||||||||||
| Priority: | P2 | ||||||||||
| Version: | 3.7.1p1 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Solaris | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Paul Bolton
2003-09-23 20:57:58 AEST
Created attachment 455 [details]
Fix for compiler warnings
Needs testing against other PAM frameworks and Solaris 8 and prior without
Solaris 9 PAM backport patch.
On one hand, PAM RFC [1] does say those params are "void **". On the other hand, the patch causes warnings with (at least) Linux PAM (which has the "const"). [1] http://www.opengroup.org/tech/rfc/mirror-rfc/rfc86.0.txt Created attachment 526 [details]
Attempt to fix warnings on other platforms too
We could do some preprocessor abuse to suppress the warnings on other platforms
or should we just live with them?
Created attachment 674 [details] Update to -current This patch makes auth-pam.c match the prototypes defined by the PAM specs for the conversation function and get_pam_item. See OSF RFC 86.0[1] (A.1 and appendix B) and and XSS0[2] (ss 5.1.2 and ch 6). It will cause warnings similar to the following on platforms that don't match the specs: auth-pam.c: In function `sshpam_thread': auth-pam.c:365: warning: passing arg 3 of `pam_get_item' from incompatible pointer type auth-pam.c:370: warning: assignment from incompatible pointer type auth-pam.c: At top level: auth-pam.c:460: warning: initialization from incompatible pointer type auth-pam.c: In function `sshpam_init': auth-pam.c:491: warning: passing arg 3 of `pam_get_item' from incompatible pointer type auth-pam.c: At top level: auth-pam.c:842: warning: initialization from incompatible pointer type auth-pam.c:908: warning: initialization from incompatible pointer type auth-pam.c:1034: warning: initialization from incompatible pointer type [1] http://www.opengroup.org/tech/rfc/mirror-rfc/rfc86.0.txt [2] http://www.opengroup.org/onlinepubs/008329799/ Applied, thanks. |