Bug 783

Summary: __unused nit
Product: Portable OpenSSH Reporter: Dag-Erling Smørgrav <des>
Component: PAM supportAssignee: OpenSSH Bugzilla mailing list <openssh-bugs>
Status: CLOSED FIXED    
Severity: normal    
Priority: P2    
Version: -current   
Hardware: All   
OS: FreeBSD   
Attachments:
Description Flags
only define __unused if it isn't already defined none

Description Dag-Erling Smørgrav 2004-01-07 00:15:21 AEDT 
auth-pam.c was originally taken from FreeBSD, which has an __unused macro which 
corresponds to GCC's __attribute__((__unused__)).  A blank definition of that 
macro was added to auth-pam.c to support platforms where it is not defined.  
This definition should be conditional on the non-existence of the macro, rather 
than unconditional.  As it stands, it causes a warning on platforms which do 
have an __unused macro.
Comment 1 Dag-Erling Smørgrav 2004-01-07 00:16:08 AEDT 
Created attachment 522 [details]
only define __unused if it isn't already defined
Comment 2 Darren Tucker 2004-01-07 12:33:56 AEDT 
Seems reasonable, but perhaps it should be moved to defines.h?
Comment 3 Darren Tucker 2004-01-08 05:33:02 AEDT 
Fixed (in defines.h).  Thanks.
Comment 4 Damien Miller 2004-04-14 12:24:20 AEST 
Mass change of RESOLVED bugs to CLOSED