Bug 842

Summary: type fixes for progressmeter
Product: Portable OpenSSH Reporter: Darren Tucker <dtucker>
Component: sftpAssignee: OpenSSH Bugzilla mailing list <openssh-bugs>
Status: CLOSED FIXED    
Severity: normal CC: djm
Priority: P2    
Version: -current   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 1353    
Attachments:
Description Flags
use u_int64_t for progressmeter
none
make sftp use off_t none

Description Darren Tucker 2004-04-15 14:03:16 AEST 
Some compilers won't cast, eg, int* to unsigned long long* and progressmeter
mixes off_t and u_int64_t which causes problems for them.

off_t can vary depending on many things including platform and large file
support, but the u_int64_t is specified by the sftp protocol.
Comment 1 Darren Tucker 2004-04-15 14:08:46 AEST 
Created attachment 604 [details]
use u_int64_t for progressmeter
Comment 2 Damien Miller 2005-11-06 03:51:57 AEDT 
Is this still relevant? What compile warnings do you see?
Comment 3 Darren Tucker 2005-11-06 19:22:36 AEDT 
The error is:
sftp-client.c:1051: cannot cast 'unsigned long long *' to 'int *'

The line in question is:
start_progress_meter(local_path, sb.st_size, &offset);

"offset" is u_int64_t, the 3rd arg of start_progress_meter is off_t.

Since off_t is usually signed, it's also a potential signed/unsigned issue.
Comment 4 Damien Miller 2007-05-17 20:25:22 AEST 
Created attachment 1287 [details]
make sftp use off_t

Perhaps it would be better for sftp to use an off_t here? I don't think the OS would support files with OFF_T_MAX < size <= UINT64_MAX anyway
Comment 5 Darren Tucker 2007-05-17 23:42:24 AEST 
(In reply to comment #4)
> Perhaps it would be better for sftp to use an off_t here? I don't think
> the OS would support files with OFF_T_MAX < size <= UINT64_MAX anyway

This seems reasonable to me.  The progressmeter code doesn't seem like it would care much if it wrapped anyway, other than producing bogus stats.
Comment 6 Damien Miller 2008-03-31 15:20:11 AEDT 
Fix shipped in 4.9/4.9p1 release.