Bug 847

Summary: Including arpa/nameser.h in inet_ntop.c can cause compile problems
Product: Portable OpenSSH Reporter: Craig Leres <mindrot10>
Component: Build systemAssignee: OpenSSH Bugzilla mailing list <openssh-bugs>
Status: CLOSED WORKSFORME    
Severity: normal    
Priority: P3    
Version: 3.8p1   
Hardware: All   
OS: SunOS   
Attachments:
Description Flags
compilation errors
none
proposed patch none

Description Craig Leres 2004-04-21 12:49:44 AEST 
When compiling under SunOS 4.1.4, it looks like arpa/nameser.h is
included twice (see bug.txt attachment).
 
Removing the include doesn't cause problems under Solaris 5.7 or
FreeBSD 4.8-RELEASE. I suspect it's not really needed at all.
Comment 1 Craig Leres 2004-04-21 12:50:40 AEST 
Created attachment 607 [details]
compilation errors
Comment 2 Craig Leres 2004-04-21 12:51:19 AEST 
Created attachment 608 [details]
proposed patch
Comment 3 Darren Tucker 2004-04-21 13:17:45 AEST 
There's still a chance that some platform, somewhere needs it.  Does the system
<arpa/nameser.h> define either _ARPA_NAMESER_H_ or __NAMESER?
Comment 4 Tim Rice 2004-04-21 13:20:10 AEST 
Craig,

Use cc -H to see where the extra arpa/nameser.h is coming from.
I think you find it's not from OpenSSH.

Even if it was, why are your system headers not protecting themselvs from
multiple includes?
Comment 5 Damien Miller 2004-12-20 10:58:05 AEDT 
8 months, no reply == closed bug
Comment 6 Darren Tucker 2006-10-07 11:36:15 AEST 
Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4.