| Summary: | timeout patches | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Matthew Vernon <matthew> | ||||
| Component: | ssh | Assignee: | OpenSSH Bugzilla mailing list <openssh-bugs> | ||||
| Status: | CLOSED WONTFIX | ||||||
| Severity: | normal | ||||||
| Priority: | P2 | ||||||
| Version: | -current | ||||||
| Hardware: | ix86 | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Matthew Vernon
2002-01-31 21:29:26 AEDT
Created attachment 14 [details]
timeout patches (work by Ian Jackson and Matthew Vernon)
1. This should really be two patches - protocol keepalives are a very different beast to connection timeouts. 2. Connection/read timeouts should use select() rather then alarm()+blocking please try to have one feature per patch. 1. as to protocolkeepalive: isn't this what tcp-keepalives are for? 2. why use sigaction? sshd does a similar thing, but just uses alarm() 3. why not wrap exchange_indentification into alarm, like sshd does? 4. not all ssh1 implementations will accept your ignore message The patch here has been partially obsoleted by the ConnectTimeout feature in CVS. The other change (banner exchange timeout) has bitrotted and the authors haven't responded in over a year. If someone wants to do a new banner exchange timeout patch, please make a new bug. Such a patch should use the time remaining from ConnectTimeout for the banner exchange, rather than adding a new option. Mass change of RESOLVED bugs to CLOSED |