Bug 1028 - sshd does not forward final non-query conversations to client during pam auth
Summary: sshd does not forward final non-query conversations to client during pam auth
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: PAM support (show other bugs)
Version: 4.0p1
Hardware: All All
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL: http://www.mindrot.org/pipermail/open...
Keywords:
Depends on:
Blocks: 1047
  Show dependency tree / graph
 
Reported: 2005-05-02 13:08 AEST by David Leonard
Modified: 2006-10-07 11:40 AEST (History)
1 user (show)

See Also:

Attachments
send output from pam modules as info text (811 bytes, patch)
2005-05-02 16:06 AEST, Darren Tucker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Leonard 2005-05-02 13:08:27 AEST 
When a PAM auth module calls through the pam_conv to display a non-prompt
message just before it returns PAM_AUTH_ERR,  sshd gets the message text and
appends it to a banner buffer to be sent later at session startup.

The problem is that because authentication fails, the buffer is never sent,
meaning the important message from the auth module never makes it to the user
client.
Comment 1 Darren Tucker 2005-05-02 16:06:08 AEST 
Created attachment 894 [details]
send output from pam modules as info text

Please try this patch (against -current but may apply to earlier versions). 
I'm not sure it does the right thing in all cases, though, so it want looking
at pretty carefully.
Comment 2 Darren Tucker 2005-07-14 13:57:00 AEST 
Does the attached patch fix the issue you're seeing?
Comment 3 David Leonard 2005-07-14 14:07:48 AEST 
(In reply to comment #2)
> Does the attached patch fix the issue you're seeing?

Yes. It has been in the vintela-openssh patches for about 2 months now and seems
pretty stable.
Comment 4 Darren Tucker 2005-07-14 14:40:28 AEST 
In that case unless there are any objections I will apply it to the main tree. 
Thanks.
Comment 5 Darren Tucker 2005-09-30 10:56:15 AEST 
Patch in attachment #894 [details] has been applied to both -HEAD and 4.2 branch.  Thanks all.
Comment 6 Darren Tucker 2006-10-07 11:40:01 AEST 
Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4.