Bug 1092 - get_remote_hostname() potentially passing uninitialised buffer to debug
Summary: get_remote_hostname() potentially passing uninitialised buffer to debug
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 4.2p1
Hardware: All All
: P2 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: 1047
  Show dependency tree / graph
 
Reported: 2005-09-26 15:15 AEST by David Leonard
Modified: 2006-10-07 11:42 AEST (History)
0 users

See Also:

Attachments
relocate check_ip_options call. (705 bytes, patch)
2005-09-26 16:30 AEST, Darren Tucker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Leonard 2005-09-26 15:15:23 AEST 
get_remote_hostname() calls check_ip_options(..., ntop)
but, at that point, ntop is an uninitialised auto.
check_ip_options(, ipaddr) then calls logit("...%.100s..", ipaddr)
which will log some binary garbage.
Comment 1 Darren Tucker 2005-09-26 16:30:05 AEST 
Created attachment 966 [details]
relocate check_ip_options call.

The obvious fix would seem to be a relocation of the check_ip_options call.
Comment 2 Darren Tucker 2005-10-03 17:55:06 AEST 
Patch applied, thanks for the report.
Comment 3 Darren Tucker 2006-10-07 11:42:20 AEST 
Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4.