Bug 1240 - Better sigaction() emulation: No NULL dereferences
Summary: Better sigaction() emulation: No NULL dereferences
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 4.4p1
Hardware: All Other
: P3 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_1
  Show dependency tree / graph
 
Reported: 2006-10-01 21:58 AEST by Ighighi
Modified: 2023-01-13 13:56 AEDT (History)
2 users (show)

See Also:

Attachments
Better sigaction() emulation on non-POSIX systems (2.34 KB, patch)
2006-10-01 22:00 AEST, Ighighi 		no flags Details | Diff
tidied diff (2.08 KB, patch)
2008-06-15 10:42 AEST, Damien Miller 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ighighi 2006-10-01 21:58:45 AEST 
If there's a reason at all to ship openbsd-compat/sigact.c these days, then a better support is needed for sigaction() and friends on non-POSIX systems.  There are NULL dereferences that shouldn't be there...
A summary of changes:
  + No NULL dereferences.
  + Added sigfillset()
  + Return -1 with errno set to EINVAL for corner cases.
Comment 1 Ighighi 2006-10-01 22:00:06 AEST 
Created attachment 1193 [details]
Better sigaction() emulation on non-POSIX systems
Comment 2 Damien Miller 2008-06-15 10:42:14 AEST 
Created attachment 1527 [details]
tidied diff

Slightly tidied diff.
Comment 3 Damien Miller 2008-06-15 10:57:18 AEST 
fix applied - thanks!
Comment 4 Damien Miller 2008-07-22 12:08:54 AEST 
Mass update RESOLVED->CLOSED after release of openssh-5.1