Bug 1379 - memory leak in process_cmdline()
Summary: memory leak in process_cmdline()
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 4.7p1
Hardware: All All
: P3 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_4_8
  Show dependency tree / graph
 
Reported: 2007-10-23 03:53 AEST by Jan Pechanec
Modified: 2008-03-31 15:22 AEDT (History)
1 user (show)

See Also:

Attachments
fix for the bug (321 bytes, patch)
2007-10-23 03:53 AEST, Jan Pechanec 		no flags Details | Diff
fixed version of the patch. The previous one wasn't complete. (523 bytes, patch)
2007-10-24 00:32 AEST, Jan Pechanec 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Pechanec 2007-10-23 03:53:55 AEST 
Created attachment 1366 [details]
fix for the bug

if anything goes wrong and Fwd was filled then listen_host/connect_host are not freed.

patch attached.
Comment 1 Jan Pechanec 2007-10-24 00:32:23 AEST 
Created attachment 1369 [details]
fixed version of the patch. The previous one wasn't complete.

in the first patch, I forgot to memset() local 'fwd' variable before checking listen_host and connect_host for non-NULL value.
Comment 2 Damien Miller 2007-11-03 11:39:43 AEDT 
fix applied - thanks
Comment 3 Damien Miller 2008-03-31 15:22:11 AEDT 
Fix shipped in 4.9/4.9p1 release.