Bug 1385 - extra backslashes in RB_PROTOTYPE
Summary: extra backslashes in RB_PROTOTYPE
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 4.7p1
Hardware: All All
: P3 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_4_8
  Show dependency tree / graph
 
Reported: 2007-10-30 05:20 AEDT by Jan Pechanec
Modified: 2008-03-31 15:22 AEDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Pechanec 2007-10-30 05:20:58 AEDT 
The RB_PROTOTYPE macro in usr/src/cmd/ssh/include/sys-tree.h has a backslash on the last line of the macro. This backslash is not needed, and it's a maintenance hazard. If somebody puts non-null text on the line following the macro, it will get sucked into the macro definition. This looks particularly easy to get tripped up by, because the last line of the macro is blank.

this issue is documented in OpenSolaris bug database as 6368560:

http://bugs.opensolaris.org/view_bug.do?bug_id=6368560
Comment 1 Damien Miller 2007-11-03 10:59:10 AEDT 
fixed - thanks.
Comment 2 Damien Miller 2008-03-31 15:22:22 AEDT 
Fix shipped in 4.9/4.9p1 release.