Bug 1443 - Missing terminating CR in identification string (RFC non-compliance)
Summary: Missing terminating CR in identification string (RFC non-compliance)
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 4.7p1
Hardware: All Linux
: P2 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_1
  Show dependency treegraph
 
Reported: 2008-02-27 05:14 AEDT by Alex R
Modified: 2008-07-22 12:21 AEST (History)
1 user (show)

See Also:


Attachments
Send and receive proto banners with CR LF for proto 2 (1.96 KB, patch)
2008-06-15 04:19 AEST, Darren Tucker
djm: ok+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex R 2008-02-27 05:14:28 AEDT
Client should terminate ID string sent during protocol version exchange with CR LF (carriage return, line feed) rather than only LF, as is done in the current version. RFC 2453 (http://tools.ietf.org/html/rfc4253#section-4.2) suggests that CR LF should be used to terminate the sent line while either CR LF or just LF may be expected in a received ID string (for compatibility with older protocol versions).
Comment 1 Darren Tucker 2008-06-15 04:19:07 AEST
Created attachment 1523 [details]
Send and receive proto banners with CR LF for proto 2

This patch changes the banner to use CR LF when running as a pure protocol 2 server (which is the default for new installs these days) and in the client when it's talking to a server with protocol 2 (regardless of whether or not the server advertises 1.99 or 2.0).

It doesn't change the behaviour when acting as a protocol 1.5 or 1.99 server, or as a 1.5 client.

This will need serious interop testing, though.
Comment 2 Darren Tucker 2008-07-01 17:25:29 AEST
Thanks for the report.  The patch has been applied and this change will be in the 5.1 release.
Comment 3 Damien Miller 2008-07-22 12:21:14 AEST
Mass update RESOLVED->CLOSED after release of openssh-5.1