Bug 1482 - SOCKS4A support
Summary: SOCKS4A support
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 5.0p1
Hardware: Other Linux
: P2 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_2
  Show dependency treegraph
 
Reported: 2008-07-05 08:16 AEST by David Woodhouse
Modified: 2009-02-23 13:35 AEDT (History)
1 user (show)

See Also:


Attachments
patch (1.84 KB, patch)
2008-07-05 08:16 AEST, David Woodhouse
no flags Details | Diff
correct patch (2.56 KB, patch)
2008-07-05 08:19 AEST, David Woodhouse
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Woodhouse 2008-07-05 08:16:15 AEST
Created attachment 1543 [details]
patch

This provides SOCKS4A support, which allows a SOCKS4 client to provide a
host name instead of an IP address. It indicates that it's doing so by
using a known-invalid IP address 0.0.0.x (where x != 0), and then
appending the NUL-terminated hostname to the connection request.

Although we check for the terminating NUL manually and the
'fatal(len %d > have %d)' should never happen, the condition for it (in
the existing processing of the username) seems to have been off-by-one;
not accounting for the terminating NUL. I've fixed that while I'm at it.
Comment 1 David Woodhouse 2008-07-05 08:19:23 AEST
Created attachment 1544 [details]
correct patch

Oops; wrong patch. Try this one. Sorry.
Comment 2 Damien Miller 2009-01-14 12:38:19 AEDT
patch applied - this will be in openssh-5.2
Comment 3 Damien Miller 2009-02-23 13:35:48 AEDT
Close bugs fixed/reviewed for openssh-5.2 release