Bug 1505 - default Solaris make does not pass DESTDIR
Summary: default Solaris make does not pass DESTDIR
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: 5.1p1
Hardware: All Solaris
: P5 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_3
  Show dependency tree / graph
 
Reported: 2008-08-14 06:02 AEST by john.bartoszewski
Modified: 2009-10-06 15:02 AEDT (History)
1 user (show)

See Also:

Attachments
pass DESTDIR in env var (586 bytes, patch)
2009-08-28 10:25 AEST, Damien Miller 		dtucker: ok+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description john.bartoszewski 2008-08-14 06:02:38 AEST 
The default make commands (/usr/ccs/bin/make, /usr/xpg4/bin/make) don't respect passing DESTDIR on the command line so if you do:

make install prefix=/opt

is not respected by:

(cd scard && $(MAKE) DESTDIR=$(DESTDIR) install)

If one uses gmake from the optional /usr/sfw/bin/gmake then it works just fine.

This is very minor, and probably won't be run across by many others.
Comment 1 Damien Miller 2009-08-18 10:13:55 AEST 
we can pass DESTDIR via:

env DESTDIR=$(DESTDIR) make

as env(1) seems to be POSIX.
Comment 2 Damien Miller 2009-08-28 10:25:16 AEST 
Created attachment 1676 [details]
pass DESTDIR in env var

This passes DESTDIR via the environment. Please test.
Comment 3 Darren Tucker 2009-08-28 10:47:09 AEST 
Comment on attachment 1676 [details]
pass DESTDIR in env var

works for me (solaris 10 x86 using /usr/ccs/bin/make)
Comment 4 Damien Miller 2009-08-28 10:48:31 AEST 
patch applied - this will be in 5.3
Comment 5 Damien Miller 2009-10-06 15:02:01 AEDT 
Mass move of RESOLVED bugs to CLOSED now that 5.3 is out.