Bug 1522 - MaxSessions=0 causes client to hang
Summary: MaxSessions=0 causes client to hang
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: 5.1p1
Hardware: All All
: P2 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_2
  Show dependency treegraph
 
Reported: 2008-09-05 13:51 AEST by Iain Morgan
Modified: 2009-02-23 13:36 AEDT (History)
1 user (show)

See Also:


Attachments
call cleanup handlers on channel open failures (552 bytes, patch)
2008-12-08 10:05 AEDT, Damien Miller
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Iain Morgan 2008-09-05 13:51:44 AEST
When MaxSessions=0 is set in the sshd_config, client connections hang.
Port forwardings requested on the ssh command-line still work, assuming
the server allows them, but the client is unresponsive to any keyborad
input. Neither ~. nor ^C will close the session.

Based on comments from Damien, the solution may be to to replace a call
to channel_free() with chan_mark_dead() in channels.c.
Comment 1 Damien Miller 2008-12-08 10:05:34 AEDT
Created attachment 1586 [details]
call cleanup handlers on channel open failures

This patch changes the way that we clean up on receipt of an open failure message so that we run the callbacks that are needed for ssh to notice that its session channel has gone away.
Comment 2 Damien Miller 2008-12-08 10:05:53 AEDT
put this on the list for 5.2
Comment 3 Damien Miller 2009-01-02 08:21:16 AEDT
patch applied - this will be in openssh-5.2. Thanks!
Comment 4 Damien Miller 2009-02-23 13:36:24 AEDT
Close bugs fixed/reviewed for openssh-5.2 release