Bug 1568 - ssh-rand-helper ignores incorrect command line arguments
Summary: ssh-rand-helper ignores incorrect command line arguments
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-rand-helper (show other bugs)
Version: 5.2p1
Hardware: ix86 Linux
: P2 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_4
  Show dependency treegraph
 
Reported: 2009-03-09 22:21 AEDT by Andreas Gustafsson
Modified: 2010-03-26 10:52 AEDT (History)
1 user (show)

See Also:


Attachments
Patch (406 bytes, patch)
2009-03-09 22:21 AEDT, Andreas Gustafsson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Gustafsson 2009-03-09 22:21:37 AEDT
Created attachment 1611 [details]
Patch

If you mistakenly run the command

  ssh-rand-helper 256

expecting it to return 256 bytes of output, ssh-rand-helper silently
ignores the error on the command line and returns 48 bytes of output.
It would be helpful to get an usage message in this case.

Also, if you enter an illegal command line option, say,

  ssh-rand-helper -z

ssh-rand-helper does print a usage message, but it will otherwise
ignore the error and will return an exit status of zero.  It would
seem more prudent to treat this as a fatal error.
Comment 1 Damien Miller 2009-11-20 15:17:03 AEDT
Applied - thanks for the patch. This will be in openssh-5.4.
Comment 2 Darren Tucker 2010-03-26 10:52:01 AEDT
With the release of 5.4p1, this bug is now considered closed.