ssh-add will now return a non-zero status when adding keys, due solely to the fact that one or more key types was never created. I propose that if a key file just doesn't exist, that is an intentional act that should not result in a non-zero exit (this is of any concern to me because I have scripts for our users that depend on a zero exit of ssh-add when they run it in order to continue, and I can't tell what other people may have done which will break, and I just think backwards compatibilty is a good thing when it is easy). I have a patch which I will attach.
Created attachment 38 [details] Patch to fix described problem
OK, the patch I had didn't take into account the fact that if you specify a file on the command line, you would get no warning that the file didn't exist. Not a good idea. So, here is an updated patch that makes sure to only disregard default files, not ones you specify.
Created attachment 39 [details] Updated patch to only disregard errors finding default keys
*** Bug 166 has been marked as a duplicate of this bug. ***
Created attachment 45 [details] this patch just affects the 'default keys'
Created attachment 49 [details] Previous patch is missing a semicolon
This patch works fine for me, and catches the additional error condition of not finding any default keys (looks like I got stuck enhancing my first pass at a patch instead of approaching it again). I'm using this one now. Thanks, Markus.
applied patch.
Mass change of RESOLVED bugs to CLOSED