Bug 1588 - sftp client produces unnecessary message upon connecting to host
Summary: sftp client produces unnecessary message upon connecting to host
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sftp (show other bugs)
Version: 5.2p1
Hardware: All All
: P2 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_4
  Show dependency tree / graph
 
Reported: 2009-04-07 14:36 AEST by J.A. Neitzel
Modified: 2010-03-26 10:51 AEDT (History)
1 user (show)

See Also:

Attachments
Patch to remove "Connecting to <host>..." message from sftp.c (506 bytes, patch)
2009-04-07 14:43 AEST, J.A. Neitzel 		no flags Details | Diff
Patch to remove "Connecting to <host>..." message from sftp.c (549 bytes, patch)
2009-04-07 14:45 AEST, J.A. Neitzel 		no flags Details | Diff
delay printing connect message until after sftp protocol is raised (2.87 KB, patch)
2009-11-20 11:29 AEDT, Damien Miller 		dtucker: ok+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description J.A. Neitzel 2009-04-07 14:36:00 AEST 

    


    


      



        
          Comment 1
        

        
          J.A. Neitzel

        

        
        

        
          2009-04-07 14:43:43 AEST
        

      






Created attachment 1624 [details]
Patch to remove "Connecting to <host>..." message from sftp.c

This patch is for Portable OpenSSH.

    


    


      



        
          Comment 2
        

        
          J.A. Neitzel

        

        
        

        
          2009-04-07 14:45:34 AEST
        

      






Created attachment 1625 [details]
Patch to remove "Connecting to <host>..." message from sftp.c

This patch is for usr.bin/ssh/sftp.c in the OpenBSD source tree.

    


    


      



        
          Comment 3
        

        
          J.A. Neitzel

        

        
        

        
          2009-04-07 15:00:31 AEST
        

      






In response to this message to the openssh-unix-dev mailing list:
https://lists.mindrot.org/pipermail/openssh-unix-dev/2009-April/027560.html
.

The removal of this message should be OK.
There is a corresponding message in the debug1 output
when user invokes sftp(1) as `sftp -v ...' .

    


    


      



        
          Comment 4
        

        
          J.A. Neitzel

        

        
        

        
          2009-05-01 22:46:34 AEST
        

      






Reset assignee to default.
Reset status to new.

    


    


      



        
          Comment 5
        

        
          Damien Miller

        

        
        

        
          2009-10-06 15:18:14 AEDT
        

      






yeah, this log line doesn't actually give you any additional information (unlike, e.g., telnet's) so I don't see any harm in nuking it, or perhaps delaying it until after the connection has been confirmed (i.e. after sftp-client.c:do_init() has returned.)

    


    


      



        
          Comment 6
        

        
          Damien Miller

        

        
        

        
          2009-11-20 11:29:33 AEDT
        

      






Created attachment 1724 [details]
delay printing connect message until after sftp protocol is raised

This delays printing the message until after the sftp session has been established (post do_init()):

djm@localhost's password:
Connected to fuyu.
sftp>

    


    


      



        
          Comment 7
        

        
          Damien Miller

        

        
        

        
          2009-11-20 11:54:20 AEDT
        

      






patch has been applied. will be in openssh-5.4

    


    


      



        
          Comment 8
        

        
          Darren Tucker

        

        
        

        
          2010-03-26 10:51:58 AEDT
        

      






With the release of 5.4p1, this bug is now considered closed.