Bug 1741 - Patch to add support for building on Haiku
Summary: Patch to add support for building on Haiku
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: 5.4p1
Hardware: ix86 Other
: P2 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_5
  Show dependency treegraph
 
Reported: 2010-03-25 06:07 AEDT by Scott McCreary
Modified: 2023-01-13 13:17 AEDT (History)
2 users (show)

See Also:


Attachments
configure.ac patch to allow for building on Haiku (972 bytes, patch)
2010-03-25 06:07 AEDT, Scott McCreary
djm: ok+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott McCreary 2010-03-25 06:07:18 AEDT
Created attachment 1819 [details]
configure.ac patch to allow for building on Haiku

Haiku has included openssh for some time now, but with every openssh release we have to repatch it.  Attached is our current patch for 5.4p1.
The patch was originally done by Ingo Weinhold (ingo_weinhold@gmx.de) on 5.0p1
http://ports.haiku-files.org/browser/haikuports/trunk/net-misc/openssh/openssh-5.2p1-haiku.diff

-scottmc
Comment 1 Darren Tucker 2010-03-25 13:06:39 AEDT
Comment on attachment 1819 [details]
configure.ac patch to allow for building on Haiku

looks pretty safe, include for 5.5p1?
Comment 2 Damien Miller 2010-03-25 16:12:31 AEDT
Comment on attachment 1819 [details]
configure.ac patch to allow for building on Haiku

>+if test -z "$have_u_int64_t" ; then
>+    AC_MSG_CHECKING([for u_int64_t type in posix/stdint.h])
>+	AC_TRY_COMPILE(
>+		[ #include <posix/stdint.h> ],
>+		[ u_int64_t a; a = 1],

This looks OK, but we don't actually check for the posix/stdint.h header nor do we include it so we actually pick up the u_int64_t definition in a central place.
Comment 3 Scott McCreary 2010-03-26 07:49:13 AEDT
So perhaps just add
AC_DEFINE(HAVE_U_INT64_T) 
to that first section for the *-*-haiku*) case, and remove the second half of that patch?
Comment 4 Darren Tucker 2010-03-26 10:29:53 AEDT
(In reply to comment #3)
> So perhaps just add
> AC_DEFINE(HAVE_U_INT64_T) 
> to that first section for the *-*-haiku*) case, and remove the second
> half of that patch?

Sounds good, committed as suggested, it will be in 5.5p1.

Thanks.
Comment 5 Damien Miller 2010-04-16 15:50:52 AEST
Mass move of bugs RESOLVED->CLOSED following the release of openssh-5.5p1