Bug 1797 - Arguments to upload_dir_internal() in sftp-client.c are swapped
Summary: Arguments to upload_dir_internal() in sftp-client.c are swapped
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sftp (show other bugs)
Version: -current
Hardware: All All
: P2 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_5_6
  Show dependency tree / graph
 
Reported: 2010-07-15 04:13 AEST by Iain Morgan
Modified: 2010-08-27 10:28 AEST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iain Morgan 2010-07-15 04:13:25 AEST 
The fifth and sixth arguments to upload_dir_internal() are swapped.

1520-           } else if (S_ISDIR(sb.st_mode)) {
1521-                   if (strcmp(filename, ".") == 0 ||
1522-                       strcmp(filename, "..") == 0)
1523-                           continue;
1524-
1525:                   if (upload_dir_internal(conn, new_src, new_dst,
1526-                       pflag, depth + 1, printflag) == -1)
1527-                           ret = -1;
1528-           } else if (S_ISREG(sb.st_mode)) {
1529-                   if (do_upload(conn, new_src, new_dst, pflag) == -1) {
1530-                           error("Uploading of file %s to %s failed!",
Comment 1 Damien Miller 2010-07-19 13:16:38 AEST 
oops, fix committed and will be in openssh-5.6. Thanks again.
Comment 2 Darren Tucker 2010-08-27 10:28:17 AEST 
With the release of OpenSSH 5.6p1 this bug is now considered closed.  If you have further problems please reopen or file a new bug as appropriate.