Bug 196 - wront sent message id on upload
Summary: wront sent message id on upload
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sftp (show other bugs)
Version: -current
Hardware: All Other
: P2 major
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-02 01:35 AEST by Jean-Pierre Stierlin
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
Fix for id clobbering (1.03 KB, patch)
2002-04-02 11:30 AEST, Damien Miller 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Pierre Stierlin 2002-04-02 01:35:08 AEST 
In sftp_client.c, do_upload() function, the 'id' variable is used for both the 
sent and the received message ids, this corrupts the id of the messages 
to send and randomly generates upload failures.

The fix is to use another variable to extract the received message id, 
status_id, as done in do_download()
Comment 1 Damien Miller 2002-04-02 11:30:06 AEST 
Created attachment 58 [details]
Fix for id clobbering
Comment 2 Damien Miller 2002-04-02 11:31:31 AEST 
Thanks for spotting this - can you please try the attached patch?
Comment 3 Damien Miller 2002-04-06 10:35:09 AEST 
Fix committed to OpenBSD CVS
Comment 4 Damien Miller 2004-04-14 12:24:18 AEST 
Mass change of RESOLVED bugs to CLOSED