Bug 1962 - command buffer struct is not freed before exit()
Summary: command buffer struct is not freed before exit()
Status: CLOSED INVALID
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: -current
Hardware: All All
: P2 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-18 04:02 AEDT by Loganaden Velvindron
Modified: 2015-08-11 23:02 AEST (History)
0 users

See Also:

Attachments
ssh memory leak diff (524 bytes, application/octet-stream)
2011-12-18 04:02 AEDT, Loganaden Velvindron 		no flags Details
portable ssh memory leak diff (480 bytes, patch)
2011-12-18 04:07 AEDT, Loganaden Velvindron 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Loganaden Velvindron 2011-12-18 04:02:07 AEDT 
Created attachment 2122 [details]
ssh memory leak diff

command is initialised but is not freed before returning from main().

All modern OS free it automatically, but I've been told it's a good practice to free it.
Comment 1 Loganaden Velvindron 2011-12-18 04:07:34 AEDT 
Created attachment 2123 [details]
portable ssh memory leak diff
Comment 2 Loganaden Velvindron 2013-06-19 20:06:38 AEST 
Upon discussion with openbsd folks on irc, most modern Unix out there free it automatically upon exit.

We can close the ticket right ?
Comment 3 Loganaden Velvindron 2013-10-22 23:22:09 AEDT 
harmless on most modern Unix.
Comment 4 Damien Miller 2015-08-11 23:02:23 AEST 
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1