Bug 2088 - memleak in do_gen_krl()
Summary: memleak in do_gen_krl()
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-keygen (show other bugs)
Version: 6.2p1
Hardware: All FreeBSD
: P5 minor
Assignee: Damien Miller
URL:
Keywords:
Depends on:
Blocks: V_6_3
  Show dependency tree / graph
 
Reported: 2013-04-15 14:27 AEST by Arthur Mesh
Modified: 2016-08-02 10:40 AEST (History)
0 users

See Also:

Attachments
potential fix (1.80 KB, application/octet-stream)
2013-04-15 14:27 AEST, Arthur Mesh 		no flags Details
potential fix for both leaks (3.10 KB, application/octet-stream)
2013-04-15 14:37 AEST, Arthur Mesh 		no flags Details
fix leaks, checking for NULL before key_free() (608 bytes, patch)
2013-04-18 12:49 AEST, Damien Miller 		dtucker: ok+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Mesh 2013-04-15 14:27:12 AEST 
Created attachment 2240 [details]
potential fix

ca is not properly freed.
Comment 1 Arthur Mesh 2013-04-15 14:37:32 AEST 
Created attachment 2241 [details]
potential fix for both leaks

Found another leak. Instead of opening another defect, I'll submit it as part of this one.
Comment 2 Damien Miller 2013-04-18 12:49:46 AEST 
Created attachment 2250 [details]
fix leaks, checking for NULL before key_free()

You need to check whether ca was actually loaded, as key_free() will fatal() if not.
Comment 3 Damien Miller 2013-04-19 11:07:38 AEST 
applied. Thanks!
Comment 4 Damien Miller 2016-08-02 10:40:49 AEST 
Close all resolved bugs after 7.3p1 release