Bug 2134 - invalid prototype for get_last_login_time()
Summary: invalid prototype for get_last_login_time()
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: 6.2p1
Hardware: Other FreeBSD
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_6_3
  Show dependency tree / graph
 
Reported: 2013-07-30 04:59 AEST by Arthur Mesh
Modified: 2016-08-02 10:42 AEST (History)
2 users (show)

See Also:

Attachments
proposed fix (525 bytes, patch)
2013-07-30 04:59 AEST, Arthur Mesh 		dtucker: ok+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Mesh 2013-07-30 04:59:19 AEST 
Created attachment 2321 [details]
proposed fix

simple fix -- found when building OpenSSH with stricter warning sets.
Comment 1 Damien Miller 2013-08-01 14:34:59 AEST 
What options did you use to catch this? Neither gcc nor clang/llvm-3.3 noticed this for me.

In any case, applied - nice catch.
Comment 2 Arthur Mesh 2013-08-02 08:24:03 AEST 
It was caught using GCC 4.2.1 (with some unknown to me patches), using the
following set of -Ws:
-Wno-pointer-sign
-Wno-error=address
-W
-Wall
-Wcast-align
-Wchar-subscripts
-Wcomment
-Werror
-Wextra
-Wformat
-Wimplicit
-Winline
-Wmissing-declarations
-Wmissing-prototypes
-Wparentheses
-Wpointer-arith
-Wreturn-type
-Wshadow
-Wstrict-aliasing
-Wstrict-prototypes
-Wswitch
-Wtrigraphs
-Wuninitialized
-Wno-unused-parameter
-Wno-unused

I am not sure which, if any of these, are causing the warning.
Comment 3 Damien Miller 2016-08-02 10:42:55 AEST 
Close all resolved bugs after 7.3p1 release