Bug 2151 - Call to upload_dir() has pflag and printflag swapped
Summary: Call to upload_dir() has pflag and printflag swapped
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sftp (show other bugs)
Version: -current
Hardware: Other Other
: P5 trivial
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_6_5
  Show dependency treegraph
 
Reported: 2013-09-11 09:46 AEST by Iain Morgan
Modified: 2016-08-02 10:41 AEST (History)
1 user (show)

See Also:


Attachments
Make definition match actual usage. (523 bytes, patch)
2013-09-11 09:46 AEST, Iain Morgan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Iain Morgan 2013-09-11 09:46:48 AEST
Created attachment 2331 [details]
Make definition match actual usage.

While working on a patch for sftp(1), I noticed that the pflag and
This seems to have been the case since the initial inclusion in 5.4.

sftp.c-718-             if (!quiet)
sftp.c-719-                     printf("Uploading %s to %s\n", g.gl_pathv[i], abs_dst);
sftp.c-720-             if (pathname_is_dir(g.gl_pathv[i]) && (rflag || global_rflag)) {
sftp.c:721:                     if (upload_dir(conn, g.gl_pathv[i], abs_dst,
sftp.c-722-                         pflag || global_pflag, 1) == -1)
sftp.c-723-                             err = -1;
sftp.c-724-             } else {
--
sftp-client.c-1643-}
sftp-client.c-1644-
sftp-client.c-1645-int
sftp-client.c:1646:upload_dir(struct sftp_conn *conn, char *src, char *dst, int printflag,
sftp-client.c-1647-    int pflag)
sftp-client.c-1648-{
sftp-client.c-1649-     char *dst_canon;
Comment 1 Damien Miller 2013-09-19 10:49:25 AEST
applied - thanks.
Comment 2 Damien Miller 2016-08-02 10:41:17 AEST
Close all resolved bugs after 7.3p1 release